Re: [libvirt] [PATCH v2 3/4] util: Remove disabling of autologin for iscsi-targets
On Mon, May 16, 2016 at 11:03:10 -0400, John Ferlan wrote:
From: Fritz Elfert <fritz(a)fritz-elfert.de>
https://bugzilla.redhat.com/show_bug.cgi?id=1331552
Instead of disabling auto-login of all scsi targets (even those
that do not "belong" to libvirt), use iscsiadm's "--op
nonpersistent"
during discovery of iSCSI targets (e.g. "iscsiadm --mode discovery
--type sendtargets") in order to avoid the node database being altered
which led to the need for the "large hammer" approach taken by
commit id '3c12b654'.
commit 3c12b6542cfc994f6b9cf3aef623767bf441c3ea
Author: Daniel P. Berrange <berrange(a)redhat.com>
Date: Fri Nov 12 15:21:48 2010 +0000
This commit removes the virISCSITargetAutologin adjustment (eg. the
setting
of node.startup to "manual"). The iscsiadm command has supported this mode
of operation as of commit id 'ad873767' to open-iscsi.
commit ad873767436f1cc242f0d4a522a2fce7133795c1
Author: Mike Christie <michaelc(a)cs.wisc.edu>
Date: Mon Mar 22 17:28:41 2010 -0500
iscsiadm: add nonpersistent mode to discovery mode
Looks like this is already around for a while so I'm okay with using the
new approach now.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/util/viriscsi.c | 30 ++----------------------------
tests/viriscsitest.c | 4 +++-
2 files changed, 5 insertions(+), 29 deletions(-)
ACK
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)