Re: [libvirt] [PATCH python v4 1/7] Introduce storage lifecycle event APIs
On Thu, Jun 16, 2016 at 10:08:55AM +0200, Jovanka Gulicoska wrote:
Storage pool lifecycle event API entry points for registering and
deregistering
storage pool events, as well as types of events associated with storage pools.
These entry points will be used for implementing asynchronous lifecycle events.
Storage pool API:
virConnectStoragePoolEventRegisterAny
virConnectStoragePoolEventDeregisterAny
virStoragePoolEventLifecycleType which has events STARTED, STOPPED, DEFINED,
UNDEFINED, and REFRESHED
This is wrong. A storage pool refresh is *not* a lifecycle change, as there
is no transition involved - the pool is simply running the whole time.
We should have a completely separate event for notifying of refreshes.
This is critical to fix before the 2.0.0 release, so I will shortly
send patches to fix the API in this respect.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|