On Thu, Mar 26, 2020 at 03:41:14PM +0100, Andrea Bolognani wrote:
On Thu, 2020-03-26 at 12:35 +0000, Daniel P. Berrangé wrote: [...]
+codestyle:
check-codestlye, maybe?
Shorter names are better for the gitlab pipeline UI display, so rather not add a generic prefix to it.
+ stage: prebuild + script: + - mkdir build + - cd build + - ../autogen.sh --prefix=$(pwd)/../vroot || (cat config.log && exit 1)
Setting --prefix is not necessary for this job.
Opps yeah.
With that dropped,
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|