On Wed, Feb 06, 2008 at 06:26:04PM +0000, Richard W.M. Jones wrote:
Atsushi SAKAI wrote:
Hi,
???Today I recognized. It would be better to write #include <pthread.h> in hash.h than hash.c. And compilation works if configure.in changes in MINGW? Would you apply this patch?
I think actually it's better to push the '#include <pthread.h>' all the way up into src/internal.h. It's required in other places, eg. in src/libvirt.c.
Yep, I agree - internal.h is the best place. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|