Re: [libvirt] [PATCH 4/7] qemu: Move qemuCaps->{kvm, tcg}CPUModel into a struct

On Fri, Apr 07, 2017 at 01:07:52PM +0200, Jiri Denemark wrote: >On Tue, Apr 04, 2017 at 12:34:49 -0400, John Ferlan wrote: >> >> >> On 03/31/2017 01:54 PM, Jiri Denemark wrote: >> > We will need to store two more host CPU models and nested structs look >> > better than separate items with long complicated names. >> > >> > Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com&gt; >> > --- >> > src/qemu/qemu_capabilities.c | 65 ++++++++++++++++++++++++++------------------ >> > 1 file changed, 39 insertions(+), 26 deletions(-) >> > >> >> There's two patches in here... One to have a separate >> virQEMUCapsCopyHostCPUData and the other to create the 'hostCPU' > >Oops, I accidentally pushed this series when I wanted to push the >"qemu: Properly reset all migration capabilities" one :-( Are you OK >with me sending the additional changes as follow-up patches rather than >reverting the patches and pushing the updated ones? > Reverting the patches and doing them right would IMO look better, especially if we ever need to backport them somewhere.