26 Aug
2014
26 Aug
'14
3:24 p.m.
On 08/26/2014 01:29 PM, Erik Skultety wrote:
According to docs/schemas/domaincommon.rng and _virDomainBlockIoTuneInfo all the iotune values are interpreted as unsigned long long, however according to qemu_monitor_json.c, qemu silently truncates numbers larger than LLONG_MAX. There's really not much of a usage for such large numbers anyway yet. This patch provides the same overflow check during a domain start as it does during setting a blkdeviotune element in qemu_driver.c and thus reports an error when a larger number than LLONG_MAX is detected. --- src/qemu/qemu_command.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
ACK and pushed with the bug link added: https://bugzilla.redhat.com/show_bug.cgi?id=1131876 Jan