Re: [libvirt] [PATCH 0/3] Fix bitmap parsing code and add tests

On Fri, Aug 16, 2013 at 12:32:06PM +0200, Peter Krempa wrote: > The bitmap parsing code might cause a crash of the application using it. > Fix it and add tests so that it doesn't happen again. > > Peter Krempa (3): > virbitmap: Refactor virBitmapParse to avoid access beyond bounds of > array > virbitmaptest: Fix function header formatting > virbitmaptest: Add test for out of bounds condition > > src/util/virbitmap.c | 38 +++++++++++++------------------- > tests/virbitmaptest.c | 60 ++++++++++++++++++++++++++++++++++++++++++++------- > 2 files changed, 67 insertions(+), 31 deletions(-) ACK to all 3. I was just going to suggest adding tests to Alex, when I saw your followup.