At 2020-05-22 23:09:21, "Michal Privoznik" <mprivozn@redhat.com> wrote:
>On 5/21/20 3:59 PM, Chen Hanxiao wrote:
>> QEMU has the ability to run a script when a NIC is brought up and down.
>> Libvirt only enables use of the up script at this time.
>> This series add support for postscript when NIC is down/detached.
>> 
>> Chen Hanxiao (3):
>>    downscript: Support network interface downscript
>>    downscript: add test case
>>    doc: downscript: updating the documentation
>> 
>>   docs/formatdomain.html.in               |  6 ++-
>>   docs/schemas/domaincommon.rng           |  8 ++++
>>   src/conf/domain_conf.c                  |  9 ++++
>>   src/conf/domain_conf.h                  |  1 +
>>   src/qemu/qemu_extdevice.c               |  4 ++
>>   src/qemu/qemu_hotplug.c                 |  6 +++
>>   tests/qemuxml2argvdata/downscript.xml   | 60 +++++++++++++++++++++++++
>>   tests/qemuxml2xmloutdata/downscript.xml | 60 +++++++++++++++++++++++++
>>   tests/qemuxml2xmltest.c                 |  1 +
>>   9 files changed, 154 insertions(+), 1 deletion(-)
>>   create mode 100644 tests/qemuxml2argvdata/downscript.xml
>>   create mode 100644 tests/qemuxml2xmloutdata/downscript.xml
>> 
>
>I don't mean to be picky, especially with new contributors (well, you 
>have one contribution already, exactly one month ago). Anyway, we 
>usually structure patches differently. In the first patch we add XML 
>parsing, formatting, RNG change, documentation and xml2xml test case. In 
>the second the feature is implemented in the driver and xml2argv test 
>case is introduced. In the third patch the news.xml is adjusted.
>
>The reason is that this way it is easier for downstream maintainers to 
>backport patches.
>
>Mind posting a v2 which follows that? Apart from a small nit in 1/3 the 
>rest looks good.
>
I've contributed to libvirt for years(from another email), but did not send
patched for years either :).

I'll post a v2 to address all the comments aroud the weekends.

Regards,
- Hanxiao