Re: [Libvir] Here the patch for virtual CPU functions.

On Fri, Aug 04, 2006 at 05:45:41AM -0400, Daniel Veillard wrote: I've just reviewed the code you committed & it looks pretty sane to me. I'd definitely want to hook up the driver API asap - it should be pretty easy todo since the logic is already split out into appropriate backend files. I'd really like to test it before we releease 0.1.4 but can't just yet - see my point below.. Whether we need the vcpu mapping in the XML really depends on whether its useful to persist this stuff, or whether its something you can just define at runtime as required. VCPU mappings really get into the realm of runtime policy which I'm not convinced really wants/needs to be part of the basic XML document data. For example, when talking in terms of policy I don't think you'd directly store info in terms of 'map vcpu-1 to host cpu 3'. Instead you'd probably want to express it as 'give domain X a dedicated fixed CPU', or 'let domain X share/float 3 cpus' with other domains. The policy/management app would then decide which particular VCPU<->Host CPU mappings to implement when starting up the domain. Such a decision would have to take into account existing VCPU pinning from other domains already running. So really IMHO we don't need to rush into adding VCPU mapping to the XML. Better to wait and see if there are apps being created which explicitly need this info persisted in the XML. One more: - expose the new APIs via virsh. Michael originally suggsted pretty much following the style of 'xm vcpu-pin' and 'vcpu-list'. Seems like a fairly reasonable pattern to follow. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|