Re: [libvirt] [PATCH v6 0/9] Work around the kernel mdev uevent race in nodedev

On 10/18/2017 09:52 AM, Erik Skultety wrote: > v5 here: > https://www.redhat.com/archives/libvir-list/2017-October/msg00440.html > > Since v5: > - fixed minor nitpicks > - added 3 more patches as per reviewer's suggestion to split some of the > changes even more > - patches {2,6,7,8,9}/9 are without any change > > Erik Skultety (9): > nodedev: Move privileged flag from udev private data to driver's state (NEW) > nodedev: udev: Introduce udevEventMonitorSanityCheck helper function (ACKed) > nodedev: udev: Convert udev private data to a lockable object (ACKed with fixes) > nodedev: udev: Remove driver locks from stateInitialize and (NEW) > stateCleanup > nodedev: udev: Unlock the private data before setting up 'system' node (NEW) > nodedev: udev: Split udevEventHandleCallback in two functions (ACKed) > nodedev: udev: Convert udevEventHandleThread to an actual thread (ACKed) > routine > util: Introduce virFileWaitForExists (ACKed) > nodedev: udev: Hook up virFileWaitForAccess to work around uevent race (ACKed) > > src/conf/virnodedeviceobj.h | 1 + > src/libvirt_private.syms | 1 + > src/node_device/node_device_udev.c | 283 +++++++++++++++++++++++++++---------- > src/node_device/node_device_udev.h | 3 - > src/util/virfile.c | 31 ++++ > src/util/virfile.h | 2 + > 6 files changed, 245 insertions(+), 76 deletions(-) > > -- > 2.13.6 > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list> w/ one minor, noted adjustment in patch 5 Reviewed-by: John Ferlan <jferlan(a)redhat.com&gt; (series) I ran through Coverity too...