Re: [libvirt] [PATCH] Add TCK script for verifying disk based storage pools

According to Daniel P. Berrange on 3/3/2010 11:46 AM: High-level review nits below. However, I still count myself as too inexperienced to offer either an ACK or NAK on this. > This adds a reasonably comprehensive test script for working with > disk based storage pools. It checks > > - Prevent re-formating an existing partition table (currently s/formating/formatting/ (multiple instances) > missing this check in libvirt) > - Formating of a partiton table > - Wiping a partition table (currently missing in libvirt) > - Creating multiple storage volumes > - Deleteing storage volumes s/Deleteing/Deleting/ > +# List of host block devices that the test suite can trash all > +# data on, for purposes of testing. You have been warned ! Indeed! > @@ -0,0 +1,127 @@ > +# -*- perl -*- > +# > +# Copyright (C) 2009-2010 Red Hat > +# Copyright (C) 2009-2010 Daniel P. Berrange Shouldn't the canonical copyright be "Red Hat, Inc.", and not just "Red Hat"?