Re: [libvirt] [PATCH 06/11] qemu: Implement pcie-to-pci-bridge controller

On Wed, 2018-04-04 at 10:58 +0200, Andrea Bolognani wrote: > On Tue, 2018-04-03 at 19:13 -0400, John Ferlan wrote: >> Is there something else perhaps a few paragraphs later that could be >> added to say what this is and how/when/why someone should want to use >> it? Including the restriction about slot=0 (whatever the FLA SHPC is)... >> Similar to dmi-to-pci-bridge... Perhaps something that would already be >> there considering my patch 1 comment for a description field or some >> sort of relationship matrix... > > Yeah, I realized today that there's some documentation for the > existing behavior of adding a dmi-to-pci-bridge that will need to > tweaked in this patch to address the changes... Once that's been > taken care of, I don't think there will be much to add, though. I've come up with the diff below, which I plan to squash in patch 8/11, when the change in behavior it documents is implemented. I have also converted the list of models to a <ul>, as agreed upon in the review for patch 1/11. Since patch 3/11 is really just an independent cleanup which doesn't need to hold up the new feature, I plan to go ahead and push the rest of the series (with the changes described above) later today. Is that okay with you, or would you rather see a full v2 posted on the list?

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 84059737d5..a5a83f56c3 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4114,10 +4114,14 @@ devices (although libvirt will never auto-assign a PCI device to a PCIe slot, it will allow manual specification of such an assignment). Devices connected to pcie-root cannot be - hotplugged. In order to make standard PCI slots available on a - system which has a pcie-root controller, a pci controller - with <code>model='dmi-to-pci-bridge'</code> is automatically - added, usually at the defacto standard location of slot=0x1e. A + hotplugged. If traditional PCI devices are present in the guest + configuration, a <code>pcie-to-pci-bridge</code> controller will + automatically be added: this controller, which plugs into a + <code>pcie-root-port</code>, provides 31 usable PCI slots (1-31) with + hotplug support (<span class="since">since 4.3.0</span>). If the QEMU + binary doesn't support the corresponding device, then a + <code>dmi-to-pci-bridge</code> controller will be added instead, + usually at the defacto standard location of slot=0x1e. A dmi-to-pci-bridge controller plugs into a PCIe slot (as provided by pcie-root), and itself provides 31 standard PCI slots (which also do not support device hotplug). In order to have