Re: [libvirt] [PATCH] bye to close(), welcome to VIR_(FORCE_)CLOSE()

On 10/22/2010 05:19 AM, Stefan Berger wrote: > Using automated replacement with sed and editing I have now replaced

> occurrences of close() with VIR_(FORCE_)CLOSE() except for one, of > course. Some replacements were straight forward, others I needed to

> attention. I hope I payed attention in all the right places... Please > have a look. This should have at least solved one more double-close > error. > > Signed-off-by: Stefan Berger&lt;stefanb(a)us.ibm.com&gt; Pre-review comment: One more thing to do, which is adding something like this to cfg.mk: sc_avoid_close: @prohibit='\<close *\(' \ in_vc_files='\.c$$' \ halt='use VIR_(FORCE_)CLOSE instead of close' \ $(_sc_search_regexp) along with adding .x-sc_avoid_close with contents of src/util/file.c to exempt the one valid use of close(). Would you mind testing 'make syntax-check' after folding that in, and addressing any other fallout that it detects, while I proceed with the rest of my review?