On Fri, Mar 12, 2021 at 06:28:18PM +0100, Andrea Bolognani wrote:
This simply calls the underlying Makefile target, but allows additional arguments to be specified in a more convenient and discoverable way.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- ci/helper | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+)
diff --git a/ci/helper b/ci/helper index 420e9b73c2..8eb521ae40 100755 --- a/ci/helper +++ b/ci/helper @@ -17,6 +17,7 @@ # <http://www.gnu.org/licenses/>.
import argparse +import os import pathlib import pty import shutil @@ -26,6 +27,34 @@ import sys
class Parser: def __init__(self): + # Options that are common to all actions that use containers + containerparser = argparse.ArgumentParser(add_help=False) + containerparser.add_argument( + "target", + help="build on target OS",
With the 'shell' action, not sure if "build" is the right word in that case, how about "perform action on target OS" -- since the "target" argument is shared among ['shell', 'build', 'test']. Reviewed-by: Erik Skultety <eskultet@redhat.com>