Re: [PATCH] NEWS: Mention removal of compile time helper program lookup, virito-net ABI check and FDC capabilities
On Thu, May 29, 2025 at 14:58:17 +0200, Ján Tomko wrote:
On a Thursday in 2025, Peter Krempa via Devel wrote:
> From: Peter Krempa <pkrempa(a)redhat.com>
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
> NEWS.rst | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index fd577021b3..884fcad2d8 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -35,6 +35,24 @@ v11.4.0 (unreleased)
> <nvram/>
> </os>
>
> + * All helper programs are now detected from ``$PATH`` during runtime
> +
> + All of the code was now converted to dynamically look up helper programs
> + in ``$PATH`` rather than doing the lookup at build time and then compiling
> + in the result.
> +
> + Programs ``mount``, ``umount``, ``mkfs``, ``modprobe``, ``rmmod``,
> + ``numad``, ``dmidecode``, ``ip``, ``tc``, ``mdevctl``, ``mm-ctl``,
> + ``iscsiadm``, ``ovs-vsctl``, ``pkttyagent``, ``bhyveload``, ``bhyvectl``,
> + ``bhyve``, ``ifconfig``, ``vzlist``, ``vzctl``, ``vzmigrate``, and the
> + tools from the lvm suite (``vgchange``, ``lvcreate``, etc..) are now not
> + needed during build and will still work properly if placed in ``$PATH``.
> +
Consider placing this into the **Packaging changes**, don't think this
is tha much interesting to end users.
Hmm, you're probably right. The thing is though that these changes were
done because distros (fedora in this case) did some shenanigans with
moving /sbin/ into /bin/ but differently based on if you upgraded or
installed freshly, which actually broke some stuff for users as paths
were compiled in.
That fact isn't obvious from what I wrote if you don't know the
backstory.
Any suggestions?
> + * qemu: Improve accuracy of FDC/floppy device support statement in capabilities
XML
> +
> + The data is now based on the presence of the controller in qemu rather than
> + just a denylist of machine types where floppies not work.
> +
> * **Bug fixes**
>
> * qemu: Fix failure when reverting to internal snapshots
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano