于 2011年02月17日 00:22, Eric Blake 写道:
On 02/16/2011 03:06 AM, Osier Yang wrote:
"qemudDomainSaveFlag" goto wrong label "endjob", which will cause error when security manager trying to restore label (regression).
As it's more reasonable to check if vm is shutoff immediately, and return right away if it is, remove the checking in "qemudDomainSaveFlag", and add checking in "qemudDomainSave".
* src/qemu/qemu_driver.c --- src/qemu/qemu_driver.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
ACK. The only other caller of qemudDomainSaveFlag is qemuDomainManagedSave, and it also checks that vm is active before calling the helper.
One nit: can you adjust the comment before qemudDomainSaveFlag to document that vm must be active (it already documents that it is a helper to be run while the lock is held).
Ok, will push it with the comments updates.
Worth applying before 0.8.8.