On Thu, May 02, 2013 at 10:08:11PM +0800, Daniel Veillard wrote:
On Thu, May 02, 2013 at 03:35:50PM +0200, Guido Günther wrote:
> On Thu, May 02, 2013 at 06:39:07PM +0800, Daniel Veillard wrote:
> > I forgot to make the rc2 release on tuesday, but looking at the
> > git state it was looking like the problem reported on rc1 had been
> > fixed, so I decided to go ahead and roll the release as scheduled
> > today. It is tagged in git and the tarball is available as usual at:
> >
> >
ftp://libvirt.org/libvirt/
> >
>
> The release tarball lacks python/sanitycheck.py (rc1) and I couldn't
> figure out why. Make dist in git adds it to the tarball. So this looks
> like a problem with tarball generation on your machine? This breaks
> running "make check".
python/sanitycheck.py is indeed not in the tarball, no idea why
thinkpad:~/libvirt -> grep EXTRA_DIST python/Makefile.am
EXTRA_DIST = \
EXTRA_DIST += sanitytest.py
thinkpad:~/libvirt ->
make check which is part of 'make rpm' internal %check passed
and the python rpms were generated. So i'm not sure the issue is
really that big.
> My last commit (as already noted in another thread) broke "make
> syntax-check" so I wonder if it's worth rolling a 1.0.5.1? With "make
> check" and "make syntax-check" fixed?
we usually make dot releases when we have a deployed version and the
bug did give trouble on deployement, is that really the case here ?
The Debian build fails since it runs "make check" and misses
sanitycheck.py but that's easily fixable. So no worries, just wanted to
point it out.
Cheers,
-- Guido
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
http://veillard.com/ | virtualization library
http://libvirt.org/