Re: [libvirt PATCH 02/12] ci: integration: Extract the integration CI main recipe to jobs.sh
On Mon, Sep 18, 2023 at 12:22:38PM +0200, Erik Skultety wrote:
Follow what's been done to other jobs in .gitlab-ci.yml and
extract the
shell logic from YAML to a function in ci/jobs.sh
Signed-off-by: Erik Skultety <eskultet(a)redhat.com>
---
ci/integration-template.yml | 36 ++----------------------------------
ci/jobs.sh | 32 ++++++++++++++++++++++++++++++++
2 files changed, 34 insertions(+), 34 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
+run_integration() {
+ # Avocado >98.0 fails with the nwfilter TCK tests, so stick with 98.0 for now
+ sudo pip3 install --prefix=/usr avocado-framework
I don't recall that mentioned problem with nwfilter, but could we have
a bug filed againts TCK and put the bug link in the comment for tracking.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|