Re: [libvirt] [PATCH] esx: Update case insensitive .vmx tests

> Commit b9efc7dc3b97ef667ab99cee884b8485ebcb2f91 made virFileHasSuffix > case insensitive. Honor this in the tests by switching vmdk to VMDK. > --- >  tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx |    2 +- >  tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml |    2 +- >  2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx > index 3626c5e..bd36cf8 100644 > --- a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx > +++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx > @@ -18,7 +18,7 @@ SCSI0.SHAREDBUS = "NONE" >  SCSI0.VIRTUALDEV = "LSILOGIC" >  MEMSIZE = "1024" >  SCSI0:0.PRESENT = "TRUE" > -SCSI0:0.FILENAME = "FEDORA11.vmdk" > +SCSI0:0.FILENAME = "FEDORA11.VMDK" >  SCSI0:0.DEVICETYPE = "SCSI-HARDDISK" >  IDE0:0.PRESENT = "TRUE" >  IDE0:0.CLIENTDEVICE = "TRUE" > diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml > index 0be570f..3131bb2 100644 > --- a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml > +++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml > @@ -14,7 +14,7 @@ >    <devices> >      <disk type='file' device='disk'> >        <driver name='LSILOGIC'/> > -      <source file='[datastore] directory/FEDORA11.vmdk'/> > +      <source file='[datastore] directory/FEDORA11.VMDK'/> >        <target dev='sda' bus='scsi'/> >      </disk> >      <interface type='bridge'> IIUC this change is not strictly required, it's just to make the .vmx file use upper case letters consistently, right?

ACK anyway. Jirka