On Wed, Feb 19, 2025 at 04:57:07PM +0100, Michal Prívozník wrote:
On 2/18/25 19:12, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
> ---
> src/libxl/libxl_domain.c | 14 ++++++++++++++
> src/qemu/qemu_validate.c | 15 +++++++++++++++
> 2 files changed, 29 insertions(+)
>
Please consider squashing in the following:
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 816ed2f349..0eb414d20d 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -332,7 +332,7 @@ libxlDomainDefValidate(const virDomainDef *def,
}
for (i = 0; i < def->os.nacpiTables; i++) {
- switch ((virDomainOsACPITable)def->os.acpiTables[i]->type) {
+ switch (def->os.acpiTables[i]->type) {
case VIR_DOMAIN_OS_ACPI_TABLE_TYPE_SLIC:
break;
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 039f5f84e6..3744252284 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -743,7 +743,7 @@ qemuValidateDomainDefBoot(const virDomainDef *def,
}
for (i = 0; i < def->os.nacpiTables; i++) {
- switch ((virDomainOsACPITable)def->os.acpiTables[i]->type) {
+ switch (def->os.acpiTables[i]->type) {
case VIR_DOMAIN_OS_ACPI_TABLE_TYPE_SLIC:
break;
Why do that ? This means we won't get warned to double check validation
when adding new constants.
With regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|