Re: [libvirt] PATCH: Support setting a disk drive serial (number)

On Tue, Aug 18, 2009 at 11:03:44AM +0200, Daniel Veillard wrote: > On Mon, Aug 17, 2009 at 06:12:55PM +0100, Daniel P. Berrange wrote: > [...] > > + if (disk->serial) > > + virBufferVSprintf(&opt, ",serial=%s", disk->serial); > > Sounds fine, just that if the content is free form maybe one need > to quote that argument > > ",serial='%s'" > > to avoid potential problems. That would be a nice idea if QEMU actually supported quoting :-) It treats the value as any character following the '=' up until the next ',' (or end of string).