Re: [libvirt] [PATCH 2/5] conf: Add pSeries features
On Thu, 2018-01-25 at 15:03 +0000, Daniel P. Berrangé wrote:
On Tue, Jan 23, 2018 at 04:45:01PM +0100, Andrea Bolognani wrote:
> We're going to introduce a number of optional, pSeries-specific
> features, so we want to have a dedicated sub-element to avoid
> cluttering the <domain><features> element.
I don't think we want todo this as all. Pretty much *every* single
existing <feature> element is architecture specific. Adding a nested
level just for pseries is making it different from existing practice
and I don't see any benefit to that.
Well, there's going to be a bunch of them added pretty soon (six
or so) plus probably more down the line, so that's already quite
a bit of clutter. My reasoning was to try and organize them the
way we already do with <kvm> and <hyperv> capabilities - even
though pSeries is not a hypervisor per se, you can kinda see
sPAPR as a specification implemented by various hypervisors, like
PowerVM and in our case QEMU/KVM. But if you think this effort is
misguided and they belong to the top-level <features> element,
then I'm okay with that too.
--
Andrea Bolognani / Red Hat / Virtualization