Re: [libvirt] [PATCH] Extra filesystem options during backend filesystem mount.
On Thu, Jul 16, 2009 at 06:06:25AM -0700, Harshavardhana wrote:
New option index added to support -o options for various netfs.
Currently added an option for glusterfs.
What effect does it have ? Or why do we want/need it
@@ -670,6 +692,12 @@ virStorageBackendFileSystemMount(virConnectPtr
conn,
}
if (pool->def->type == VIR_STORAGE_POOL_NETFS) {
+ if (pool->def->source.format = VIR_STORAGE_POOL_NETFS_GLUSTERFS) {
+ if (virAsprintf(&options, "direct-io-mode=1") == -1) {
+ virReportOOMError(conn);
+ return -1;
+ }
+ }
Normally direct-IO mode is something you'd let apps set on a per file
basis as they desire. QEMU / Xen both know todo this, so I'm not
convinced we should force it on for the whole mount point.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|