Re: [libvirt] [PATCH v2 3/5] Introduce virDomainSuspendForDuration API

On 01/26/2012 12:59 PM, Michal Privoznik wrote: I'm not reviewing 1, 2, or 4(as Dan said, there's still some churn on the qemu side), but I can review this one and 5 for accuracy, assuming you make the agreed name changes. This is _not_ an OR'd set, but a linear list. I'd say: @target: a value from virNodeSuspendTarget I'd still document this for its intended purpose: @duration: duration in seconds to suspend, or 0 for indefinite as well as a disclaimer in the rest of the text stating that some hypervisors require 0 for @duration. Rather than abbreviating with "ditto", I'd copy and paste one of the other lines where we say things are unused, pass 0. That didn't read well. I'd say something like: Attempt to have the guest enter the given @target power management suspension level. If @duration is non-zero, also schedule the guest to resume normal operation after that many seconds, if nothing else has resumed it earlier. Some hypervisors require that @duration be 0, for an indefinite suspension. Looks like you get to rebase on top of other API added today. -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org