Re: [libvirt] [PATCH 1/6] qemu: add capability detection for query-cpus-fast
On 03/02/2018 12:44 PM, Peter Krempa wrote:
On Fri, Mar 02, 2018 at 10:29:06 +0100, Viktor Mihajlovski wrote:
> Detect whether QEMU supports the QMP query-cpus-fast API
> and set QEMU_CAPS_QUERY_CPUS_FAST in this case.
>
> Signed-off-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com>
> Reviewed-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com>
> ---
> src/qemu/qemu_capabilities.c | 4 +++-
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
ACK, although you should add a qemucapabilitiestest case for the new
qemu supporting this command first probably.
Shouldn't this test come along
automatically when the QEMU 2.12
replies/xml files containing the new qmp method is introduced?
Or are you suggesting to create new QEMU 2.11_patched replies/xml files
to test this?
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294