Re: [libvirt PATCH v2 4/5] m4: virt-xdr: rewrite XDR check
On Fri, 2020-07-10 at 14:12 +0200, Pavel Hrdina wrote:
On Fri, Jul 10, 2020 at 01:13:00PM +0200, Andrea Bolognani wrote:
> On Fri, 2020-07-10 at 12:25 +0200, Pavel Hrdina wrote:
> > +%if 0%{?fedora} || 0%{?rhel}
> > BuildRequires: libtirpc-devel
> > %endif
>
> We only support building RPMs on Fedora and RHEL, so this check is
> effectively a no-op.
OK, I'll drop it before pushing.
Cool. Everything else looks reasonable, so under the assumption that
you've made sure it actually builds on all supported targets
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization