Re: [libvirt PATCH 2/2] ci: Add Ubuntu 22.04
On Fri, May 06, 2022 at 10:29:32AM +0200, Michal Prívozník wrote:
On 5/6/22 10:03, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> ci/containers/ubuntu-2204.Dockerfile | 101 +++++++++++++++++++++++++++
> ci/gitlab.yml | 16 +++++
> ci/manifest.yml | 2 +
> 3 files changed, 119 insertions(+)
> create mode 100644 ci/containers/ubuntu-2204.Dockerfile
>
> @@ -592,6 +599,15 @@ x86_64-ubuntu-2004-clang:
> UBSAN_OPTIONS: print_stacktrace=1:halt_on_error=1
>
>
> +x86_64-ubuntu-2204:
> + extends: .native_build_job
> + needs:
> + - x86_64-ubuntu-2204-container
> + allow_failure: false
> + variables:
> + NAME: ubuntu-2204
> +
> +
>
> # Cross build jobs
>
> diff --git a/ci/manifest.yml b/ci/manifest.yml
> index e221cd54f3..9a643be5b8 100644
> --- a/ci/manifest.yml
> +++ b/ci/manifest.yml
> @@ -223,3 +223,5 @@ targets:
> CC: clang
> MESON_ARGS: -Db_lundef=false -Db_sanitize=address,undefined
> UBSAN_OPTIONS: print_stacktrace=1:halt_on_error=1
> +
> + ubuntu-2204: x86_64
Any reason we don't want to run ASAN on new Ubuntu? Or we do that only
for clang?
We only need ASAN running on one job and which one is pretty much
arbitrary unless someone can point to clear benefits for one over
the other wrt ASAN results.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|