Re: [libvirt] [PATCH] esx: Handle non-UTF-8 encoded VMX files

>> + >> + if (result == NULL) { >> + virReportOOMError(); >> + goto cleanup; >> + } >> + >> + cleanup: > > Is that last goto necessary, since the label is reached next anyways? Maybe this is a defensive goto, assuming that someday someone may add extra code after that if clause. And for the moment it's just a single jmp that gets optimized out. (kind of like putting a break on the last case of a switch statement. It doesn't do anything now, but may save your bacon later if Ralph Wiggum goes playing in your code ;-))