On Fri, Aug 16, 2019 at 09:52:02 +0200, Erik Skultety wrote:
On Fri, Aug 16, 2019 at 09:43:27AM +0200, Peter Krempa wrote:
> In some cases e.g. with clang on fedora 30 __open2 isn't even declared
> which results in the following build error:
>
> /home/pipo/libvirt/tests/virpcimock.c:939:1: error: no previous prototype for
function
> '__open_2' [-Werror,-Wmissing-prototypes]
> __open_2(const char *path, int flags)
>
> Add a separate declaration to appease the compiler.
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
I guess you could have simply pushed this as a build breaker, anyway:
I find this solution kind of ugly, that's why I wasn't completely
persuaded to push it right away.