On Wed, Feb 25, 2015 at 11:50:37AM +0100, Michal Privoznik wrote:
On 25.02.2015 11:30, Martin Kletzander wrote:
> The "virtio-mmio" is perfectly valid address type which we parse and
> format correctly, but it's missing in our RNG schemas, hence editing a
> domain with device having such address fails the validation.
>
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
> docs/schemas/domaincommon.rng | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index f41ca43..6e73e7c 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -4415,6 +4415,11 @@
> </attribute>
> <ref name="isaaddress"/>
> </group>
> + <group>
> + <attribute name="type">
> + <value>virtio-mmio</value>
> + </attribute>
> + </group>
> </choice>
> </element>
> </define>
>
This should be backported all the way down till 1.1.3 maint branches.
As with other schema changes, I think this makes sense for
1.2.12-maint *at most*. Feel free to back-port it though, if you have
a reason.