Re: [libvirt] [PATCH] Add libvirt-daemon-vbox & libvirt-daemon-driver-vbox RPMs

On 05/17/2013 07:29 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > > Now the VirtualBox driver is a loadable module, it needs > to live in its own sub-RPM > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > --- > libvirt.spec.in | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > + > + %if %{with_vbox} > +%package daemon-vbox > +Summary: Server side daemon & driver required to run VirtualBoxguests s/VirtualBoxguests/VirtualBox guests/ > +Group: Development/Libraries > + > +Requires: libvirt-daemon = %{version}-%{release} > + %if %{with_driver_modules} > + %if %{with_vbox} Kill this %if. It's redundant with the condition a few lines earlier (the Requires can be unconditional). > +Requires: libvirt-daemon-driver-vbox = %{version}-%{release} > + %endif ACK with those fixes. Do we need a followup patch to mingw-libvirt.spec.in?