On Wed, Mar 26, 2014 at 7:52 AM, Claudio Bley <cbley(a)av-test.de> wrote:
At Wed, 26 Mar 2014 03:29:34 +0000,
Chris Ellis wrote:
>
> Update the pom to set the Java source level. This enables Eclipse
> to correctly configure itself.
So, you let ant generate the pom.xml and use that with Eclipse, right?
Yes, once there is a valid pom you can just import the project into Eclipse
via the Eclipse / Maven integration.
Is there any reason we are building via Ant, rather than using Maven for
the
build?
> Also include plugins to publish the source and javadocs vai Maven.
s/vai/via
> Update .gitignore to exclude a local pom.
> ---
> .gitignore | 1 +
> pom.xml.in | 41 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 42 insertions(+)
> diff --git a/pom.xml.in b/pom.xml.in
> index 4f49a3a..fd743ad 100644
> --- a/pom.xml.in
> +++ b/pom.xml.in
> @@ -30,6 +30,47 @@
> <version>[3.4.1,4.0.0]</version>
> </dependency>
> </dependencies>
> +
^^^^^
trailing whitespaces (git warns about this)
ACK, but I did not yet push it since your patch is not against
libvirt-java master.