Re: [libvirt] [PATCH 02/10] util: error: Fix error message strings to play well with additional info
On Thu, Dec 06, 2018 at 08:56:59AM +0100, Erik Skultety wrote:
On Wed, Dec 05, 2018 at 05:47:43PM +0100, Peter Krempa wrote:
> Additional information for a string is always in form of a string or
s/for a string/for an error message
s/always/either
> empty. Fix two offenders. One used %d as format modifier and
second
s/as /as the
s/ second/the second one
> always expected a string. Both are thankfully unused currently.
Doesn't sound 100% right...how about:
"Thankfully, neither of the offenders are currently in effect."
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
^^This still stands though, it's just the commit message activated the
"grammar <noun_placeholder>" in me for some reason :P, sorry.
Erik