On 06/09/2010 06:07 AM, Daniel P. Berrange wrote:
If desired, a later patch can add hooks (either a new XML element, or a new command comparable to autostart that can toggle the state of a hidden field associated with domains) so that virDomainCreate() can also be used to start a paused domain, but that will be more invasive.
IMHO we really need to make this work for both APIs. The fact that VDSM only uses virDomainCreateXML is an application specific use case & not something we should be relying on. Since the virDomainCreate() API lacks a flags parameter, we need to define a new API virDomainCreateFlags() which it adds it. That lets us get parity of functionality between transient and persistent guests.
This series looks ok, but I'd like the other API implemented before we commit this.
Sounds good - I'm on it! -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org