On 10/09/2012 07:39 AM, Peter Krempa wrote:
The comment stated that you may call qemuDomainObjBeginJobWithDriver() without passing qemud_driver to signalize it's not locked.
signalize is a valid spelling, but unusual; I'd write it 'signal'.
qemuDomainObjBeginJobWithDriver still accesses the qemud_driver structure and the lock singalling is done through a separate parameter.
s/singalling/signaling/
--- src/qemu/qemu_domain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 17ae3b9..19ba099 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -884,8 +884,7 @@ int qemuDomainObjBeginAsyncJob(struct qemud_driver *driver, }
/* - * obj must be locked before calling. If qemud_driver is passed, it MUST be - * locked; otherwise it MUST NOT be locked. + * obj and qemud_driver must be locked before calling.
ACK. This one can be applied independently of my pending patches (aargh, I still need to get those rebased with comments addressed...). -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org