Re: [libvirt] [PATCH] Fix compiler warnings in test code

On Tue, Dec 16, 2008 at 06:51:14PM -0800, john.levon(a)sun.com wrote: > # HG changeset patch > # User john.levon(a)sun.com > # Date 1229399267 28800 > # Node ID 1b81ac255ad765ab782829e7fe0a55dc7bab72ab > # Parent ee6ccfc062f49f514d7ae8924d5a596b18441fee > Fix compiler warnings in test code > > Signed-off-by: John Levon <john.levon(a)sun.com&gt; > > diff --git a/src/test.c b/src/test.c > --- a/src/test.c > +++ b/src/test.c > @@ -1299,7 +1299,7 @@ static unsigned long testGetMaxMemory(vi > static unsigned long testGetMaxMemory(virDomainPtr domain) { > testConnPtr privconn = domain->conn->privateData; > virDomainObjPtr privdom; > - unsigned long ret = -1; > + unsigned long ret = (unsigned long)-1; The original code was actually bogus. It should have been initialized to '0' as the error return value, rather than the current '-1'.