On Mon, Mar 27, 2017 at 09:58:17AM +0200, Michal Privoznik wrote:
On 24.03.2017 19:59, Martin Kletzander wrote:
> Don't get pushed away just because it is 23 patches. They are almost
> one-liners. Just a lot of stuff I got dragged into, lot of rabbit
> holes where I reached the end, basically lot of side fixes. That's
> mostly due to one of the bigger changes being removed from the series
> completely about two days ago when I realized I'm not spending week of
> fixing terribly tricky stuff just so we can test one more teeny tiny
> thing that's not even needed (which I realized way too late).
>
> The patches are available on github:
>
>
https://github.com/nertpinx/libvirt -- branch pre-cat
>
> The patches should be *really* nice to review, and there's lot of
> cleanups. The only reason for this patch-series to add more lines
> than remove them, is because it adds tests. And tests are good and
> yummy. Me like tests... Yeah, I guess it's Friday, 8PM. I should go
> home... Bye.
>
>
> Martin Kletzander (23):
> Add virNumaGetNodeCPUs to private syms
> Introduce virCPUProbeHost
> Expose virCapabilitiesFreeGuest
> vmware: Fix some initialization problems
> cpu: Don't use prefixes for no reason
> syms: Add one newline to make things consistent
> tests: Fix indentation in virhostcputest
> vz: Do not use magic constants when building capabilities
> Separate syms based on files they are defined in
> openvz: Ditch openvzGetNodeCPUs
> tests: Remove some unneeded files
> virfile: Add helpers for reading simple values
> tests: Add cpu/{online,present} files for old tests
> util: Add virsysfs for handling sysfs files
> util: Adapt virhostcpu to the new virsysfs
> Move src/fdstream to src/util/virfdstream
> Remove src/nodeinfo
> util: Fix naming in util/virnodesuspend
> Change virQEMUCapsInitPages to virCapabilitiesInitPages
> tests: Add sysfs node/cpu topology for the only vircaps2xml testcase
> tests: Add linux-caches sysfs entries for vircaps2xmltest
> tests: Add virnumamock
> tests: Enhance vircaps2xml test
>
[...]
ACK series.
Michal
Thanks, I adjusted what you pointed out and will push it in a while.
Martin