Re: [libvirt] [PATCH v2 1/9] Functions for computing baseline CPU from a set of host CPUs

> > + for (i = 0; i < ncpus; i++) { > > + doc = xmlParseMemory(xmlCPUs[i], strlen(xmlCPUs[i])); > > + if (doc == NULL || (ctxt = xmlXPathNewContext(doc)) == NULL) > > + goto no_memory; > > Hum, no, doc == NULL might come from parsing error, raising an OOMError > in that case sounds weird, unless you're 100% sure this is well formed > XML... Hmm, right. If you don't mind I will address this separately together with similar older code.