Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

At Mon, 3 Mar 2014 15:58:25 +0000, Daniel P. Berrange wrote: > > On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: > > At Fri, 21 Feb 2014 11:01:47 +0000, > > Daniel P. Berrange wrote: > > > > > > ACK, if you also add the virEventUpdateTimeout method > > > > OK, but why should I add it? It's useless (for the user) and unused by > > the wrapping code. I want to keep the JNA library definition clean -- > > e.g. in a later patch I remove all the *UUIDString functions. > > What makes you say it is useless ? I don't regard the JNA mappings part of the public API of the Java bindings. It is a private implementation detail, which is (alas) public solely due to technical/historical reasons. So, it is useless for the user, because there is no way that he can use it (via the /public/ API)... Furthermore, I think there is no reason to expose those functions to the user at all. There are other means to program timeouts in Java than using the JNA wrapped libvirt functions where you have to run an event loop and take some speed drawbacks into account (libffi / native code to Java transition).