Re: [libvirt] [PATCHv2 3/3] snapshot: rudimentary qemu support for atomic disk snapshot

On 03/17/2012 05:33 PM, Eric Blake wrote: > Taking an external snapshot of just one disk is atomic, without having > to pause and resume the VM. This also paves the way for later patches > to interact with the new qemu 'transaction' monitor command. >

> +++ b/src/qemu/qemu_driver.c > @@ -10279,6 +10295,12 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain, > &vm, snap, flags)< 0) > goto cleanup; > } else if (!virDomainObjIsActive(vm)) { > + if (flags& VIR_DOMAIN_SNAPSHOT_CREATE_ATOMIC) { > + qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > + _("atomic snapshots of inactive domains > not " > + "implemented yet")); > + goto cleanup; I wonder if we shouldn't add a error code for unimplemented functionality to differentiate it from unsupported configurations. (Well, but using a configuration that uses unimplemented functionality makes it an unsupported configuration basically, so I don't really mind)

> + } > if (qemuDomainSnapshotCreateInactive(driver, vm, snap)< 0) > goto cleanup; > } else { ACK,