On 04/08/2014 09:37 AM, Daniel P. Berrange wrote:
The virNWFilterTechDriver struct is nothing todo with the nwfilter
s/todo/to do/
XML configuration. It stores data specific to the driver implementation so should be in a header in the driver directory instead.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/Makefile.am | 1 + src/conf/nwfilter_conf.h | 86 ---------------------- src/nwfilter/nwfilter_dhcpsnoop.h | 2 + src/nwfilter/nwfilter_ebiptables_driver.h | 2 + src/nwfilter/nwfilter_gentech_driver.h | 1 + src/nwfilter/nwfilter_learnipaddr.h | 1 + src/nwfilter/nwfilter_tech_driver.h | 115 ++++++++++++++++++++++++++++++ 7 files changed, 122 insertions(+), 86 deletions(-) create mode 100644 src/nwfilter/nwfilter_tech_driver.h
+ +enum virDomainNetType;
Do we still need this forward declaration, or now that it is in a dedicated header can it just include the correct prereq file? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org