Re: [PATCH 1/1] cpu_riscv64.c: add update() implementation

On Fri, Apr 28, 2023 at 02:15:04PM -0300, Daniel Henrique Barboza wrote: > On 4/28/23 12:40, Andrea Bolognani wrote: >> On Thu, Apr 27, 2023 at 06:04:10PM -0300, Daniel Henrique Barboza wrote: >>> At this moment it is not possible to launch a 'riscv64' domain of type >>> 'qemu' (i.e. TCG) and machine 'virt' in a x86 host: >>> >>> $ sudo ./run tools/virsh start riscv-virt1 >>> error: Failed to start domain 'riscv-virt1' >>> error: this function is not supported by the connection driver: >>> cannot update guest CPU for riscv64 architecture >> >> I get a different error message, specifically >> >> unsupported configuration: CPU mode 'custom' for riscv64 qemu >> domain on x86_64 host is not supported by hypervisor > > Ha, I believe the patch is still relevant but I did a serious mess in the commit > message :( > > The difference between what we're seeing is that I used a QEMU from riscv-to-apply.next > from the maintainer tree [1] instead of master. I was thinking about libvirt's master branch rather than QEMU's, but that makes sense. I'll check out v2 after building QEMU from the appropriate branch. > commit c13dfff2ded9cf2098a07e2426ffcad674602030 > Author: Daniel Henrique Barboza <dbarboza(a)ventanamicro.com&gt; > Date: Tue Apr 11 15:35:10 2023 -0300 > > target/riscv: add query-cpy-definitions support Since this hasn't made its way into master yet, maybe you can still get the maintainer to s/cpy/cpu/ for you? :)