Re: [libvirt] [PATCH] nodeinfo: don't define nodeGetCellMemory if it isn't ever used
On 03/11/2013 03:20 AM, Hu Tao wrote:
On Mon, Mar 11, 2013 at 05:12:25PM +0800, Osier Yang wrote:
> On 2013年03月11日 16:57, Hu Tao wrote:
>>
>> Signed-off-by: Hu Tao<hutao(a)cn.fujitsu.com>
>> ---
>> src/nodeinfo.c | 10 ++--------
>> 1 file changed, 2 insertions(+), 8 deletions(-)
> But I like this more, as it avoids the "WITH_NUMACTL".
> nodGetCellMemory can be removed on the #else branch indeed as it's
> only for internal use, the caller already errored out if no
> WITH_NUMACTL.
>
> So ACK.
Thanks!
Pushed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)