Anno domini 2009 Matthias Bolte scripsit:
2009/6/10 Doug Goldstein <cardoe@gentoo.org>:
This patch adds a new function virFindFileInPath() and uses it to find where a binary lives in the PATH environment variable. [...]
+char *virFindFileInPath(const char *file) +{ [...] +}
GCC (version 4.3.3 here) warns about "initialization from incompatible pointer type" at this line:
char *penv = &pathenv; /* this is for glibc 2.10 strsep chnages */
Changing it to
char *penv = pathenv; /* this is for glibc 2.10 strsep chnages */
fixes the warning.
At first I was surprised that the first version with & works and gives correct results, then I checked that actual values that are assigned to char *penv and it's the same in both cases. But the point is: the additional & triggers a warning (breaks compilation with --enable-compile-warnings=error) and removing it doesn't change the behavior.
As we found this subtle "bug"(?) - at least it's questionable why the '&' was added, which does not change the semantics for the stack var - by the mails our libVirt build daemon sends to the two of us, I wanted to raise the question, if this service might be of public interest? It would be no problem for to forward the mails (max. one per hour, IFF a new commit could be pulled from the public GIT repository) to any of the libVirt lists or maybe I'm even able to setup an own one. I would prefer the first option, though. Anybody interested? Ciao Max -- Follow the white penguin.