Re: [PATCH 0/2] Fix wrong copy of encryption 'usage' string

On a Thursday in 2020, Peter Krempa wrote:

Copying the pointer caused double-free when clearing the domain object.

Peter Krempa (2): virSecretLookupDefCopy: Remove return value virStorageEncryptionSecretCopy: Properly copy internals

src/util/virsecret.c | 3 +-- src/util/virsecret.h | 4 ++-- src/util/virstorageencryption.c | 8 +++----- src/util/virstoragefile.c | 3 +-- 4 files changed, 7 insertions(+), 11 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano