Re: [libvirt] [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised

Currently, osstest wrongly thinks that ARM can do save/restore, because `virsh help' does mention the save command (on all architectures). Additionally, check the virth capabilities xpath /capabilities/host/migration_features to try to see whether this host supports migration.

I am not sure if this is the right path to check. Perhaps /capabilities/host/migration_features/live is more correct, but this may be wrong if Xen comes to support save/restore on ARM, but not live migration (but perhaps libvirt cannot express this distinction in which case perhaps it's right after all).

Signed-off-by: Ian Jackson <Ian.Jackson(a)eu.citrix.com&gt; CC: Julien Grall <julien.grall(a)arm.com&gt; CC: Jim Fehlig <jfehlig(a)suse.com&gt; --- Osstest/Toolstack/libvirt.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm index b7db7af..250fe47 100644 --- a/Osstest/Toolstack/libvirt.pm +++ b/Osstest/Toolstack/libvirt.pm @@ -111,7 +111,9 @@ sub check_for_command($$) { sub saverestore_check ($) { my ($self) = @_; - return check_for_command($self, "save"); + return + _check_capability($self, '/capabilities/host/migration_features') && + check_for_command($self, "save"); } sub migrate ($$$$) { -- 2.1.4 -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list