Re: [libvirt] [PATCH 0/4] Add support for an XKCD mode

On Fri, Apr 01, 2016 at 12:30:26 +0100, Daniel P. Berrange wrote: > The XKCD website primarily publishes comics, but many of them > are in fact design blueprints showing best practice for software > developers. A number of these designs are applicable to libvirt > and will provide valuable features to our users. This series > introduces a new framework for enabling these enhanced features > via a so called "XKCD mode". They are not enabled by default > since we want to retain backwards compatibility for existing > users. Users of libvirt though are encouraged to enable as many > of the features as possible for their deployments. > > Daniel P. Berrange (4): > xkcd: add initial framework to enabling XKCD mode > xkcd: enable more efficient random number generator > xkcd: enabling pre-processing of XML with perl > xkcd: generate secure rememberable qcow2 passwords > > src/Makefile.am | 2 + > src/libvirt_private.syms | 4 ++ > src/util/virrandom.c | 26 ++++++++----- > src/util/virstorageencryption.c | 47 ++++++++++++---------- > src/util/virxkcd.c | 86 +++++++++++++++++++++++++++++++++++++++++ > src/util/virxkcd.h | 31 +++++++++++++++ > src/util/virxml.c | 35 ++++++++++++++--- > 7 files changed, 194 insertions(+), 37 deletions(-) > create mode 100644 src/util/virxkcd.c > create mode 100644 src/util/virxkcd.h ACK and safe for the release.