Re: [libvirt] [PATCH v1 6/6] ivshmem: add start param to server attribute
On 2014/8/28 5:20, Maxime Leroy wrote:
On Tue, Aug 26, 2014 at 11:58 AM, Wang Rui
<moon.wangrui(a)huawei.com> wrote:
> On 2014/8/22 18:47, Maxime Leroy wrote:
>
>> +# util/virivshmemserver.h
>> +virStartIvshmemServer;
>> +virStopIvshmemServer;
>
> I think function name virIvshmemStartServer is better.
> So is the stop function.
>
What about virIvshmemServerStart ?
It looks fine.
>> @@ -5120,6 +5121,12 @@
qemuBuildIvshmemCommandLine(virCommandPtr cmd,
>> return -1;
>> virCommandAddArg(cmd, devstr);
>> VIR_FREE(devstr);
>> +
>> + if (ivshmem->server.start == VIR_TRISTATE_BOOL_YES) {
>> + if (virStartIvshmemServer(dev->name,
ivshmem->server.path,
>> + ivshmem->size,
ivshmem->msi.vectors))
>> + return -1;
>> + }
>> }
>
> I'm not sure that calling virStartIvshmemServer in qemuBuildIvshmemCommandLine
> is the best way. Maybe qemuBuild*CommandLine() usually only build commandline.
>
Calling virStartIvshmemServer in qemuProcessStart should be better ?
Looks better, too. But we'd better to wait for other opinions.
Maxime