Re: [libvirt] [PATCH 12/28] Convert avahi check to use LIBVIRT_CHECK_PKG
On 01/11/2013 04:05 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
configure.ac | 34 ++--------------------------------
m4/virt-avahi.m4 | 26 ++++++++++++++++++++++++++
2 files changed, 28 insertions(+), 32 deletions(-)
create mode 100644 m4/virt-avahi.m4
- AC_HELP_STRING([--with-avahi], [use avahi to advertise remote
daemon @<:@default=check@:>@]),
+
+AC_DEFUN([LIBVIRT_CHECK_AVAHI],[
+ LIBVIRT_CHECK_PKG([AVAHI], [avahi-client], [0.6.0])
Hmm. I just noticed that the new './configure --help' message is more
generic for every library we've been replacing, such as:
--with-avahi with libavahi-client support [default=check]
Should we enhance LIBVIRT_CHECK_PKG to add an optional fourth parameter,
which is additional hint text to add to the AS_HELP_STRING message about
WHY using the library might be worthwhile? That is, I'm thinking
something like:
LIBVIRT_CHECK_PKG([AVAHI], [avahi-client], [0.6.0],
[used for advertising remote daemon])
and generating:
--with-avahi with libavahi-client support [default=check],
used for advertising remote daemon
But that's an independent question, and affects ALL of the converted
libraries, so it does not prevent me from giving:
ACK as-is.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)