Re: [libvirt] [Qemu-devel] [PATCH 2/2] target-i386: Disable kvm_mmu_op by default on pc-1.4
On Fri, Jan 04, 2013 at 08:48:42PM +0000, Blue Swirl wrote:
[...]
> +/* machine init function for pc-0.14 - pc-1.2 */
> static void pc_init_pci(QEMUMachineInitArgs *args)
> {
> ram_addr_t ram_size = args->ram_size;
> @@ -232,12 +233,20 @@ static void pc_init_pci(QEMUMachineInitArgs *args)
> initrd_filename, cpu_model, 1, 1);
> }
>
> +/* machine init function for pc-1.3 */
The comment does give much information compared to the function name.
You can't be sure from the function name if it's just for
1.3 or for 1.3 and higher/lower. e.g. before this patch, the
pc_init_pci_1_3() function was used by both pc-1.3 and pc-1.4.
But I will change this, anyway: I will document only the non-trivial
cases (that don't apply to only one machine-type version), it should be
better than redundant comments.
[...]
> +void disable_kvm_mmu_op(void)
> +{
> +#ifdef CONFIG_KVM
> + if (kvm_enabled())
Braces.
Will be fixed in the next version.
--
Eduardo